Improvement/no dashboards handling #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Southeaven
changed the title
marcin-witaszek-wttech
approved these changes
Nov 18, 2019
tMaxx
approved these changes
Nov 18, 2019
|
|
||
| export const StyledNotFound = styled(BaseNoData(NotFound))` | ||
| background: #211f39; | ||
| z-index: 2000; |
There was a problem hiding this comment.
Is this ok ? is board drawer still accessible?
There was a problem hiding this comment.
Drawer is accessible when there are no boards and app is showing component responsible for adding first board (scope of this pull request). Drawer won't be accessible when app is showing NotFound component, but it wasn't showing drawer before this PR as well.
There was a problem hiding this comment.
Can You send me a screenshot on Slack
szymon-owczarzak
approved these changes
Nov 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.