Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use io.knotx.distribution Gradle plugin #43

Closed
tomaszmichalak opened this issue Sep 11, 2019 · 2 comments
Closed

Use io.knotx.distribution Gradle plugin #43

tomaszmichalak opened this issue Sep 11, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@tomaszmichalak
Copy link

Is your feature request related to a problem? Please describe.

Knot.x Distribution Gradle plugin (io.knotx.distribution) allows to easily download Knot.x distribution (Knot.x Stack) with all dependencies and integrate them with custom modules.

Describe the solution you'd like
Use the io.knotx.distribution plugin instead of gradle/distribution.gradle.kts. Please check Knot.x Starter Kit as a reference.

Please check lines:

tasks.register("prepareDocker") {
    dependsOn("cleanDistribution", "overwriteCustomFiles", "copyDockerfile")
}

Additional context
Improvements can be added with next versions of the plugin.

@szymon-owczarzak szymon-owczarzak added the enhancement New feature or request label Sep 24, 2019
@szymon-owczarzak
Copy link
Contributor

Thanks @tomaszmichalak, do You think if this is still valid if we have custom changes in gradle/distribution.gradle.kts ?

@szymon-owczarzak szymon-owczarzak self-assigned this Jan 17, 2020
szymon-owczarzak added a commit that referenced this issue Jan 20, 2020
)

* Use distribution plugin more

* Update KnotX to 2.10
@szymon-owczarzak
Copy link
Contributor

Implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants