Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config not recteated after delete #236

Closed
szymon-owczarzak opened this issue Jan 22, 2020 · 1 comment
Closed

Config not recteated after delete #236

szymon-owczarzak opened this issue Jan 22, 2020 · 1 comment
Assignees
@mpiotrowski1
Labels
bug Something isn't working

Comments

@szymon-owczarzak
Copy link
Contributor

szymon-owczarzak commented Jan 22, 2020 •
edited
Loading

Describe the bug
If /mnt/config.json is removed when app is running then after refresh app is no longer working.
When config.json is missing it is created on demand on startup - this should be done each time when config is missing.

To Reproduce
Steps to reproduce the behavior:

  1. Remove config.json on running app
  2. Refresh page
  3. App does not work

Expected behavior
App is still working

Workaround
Restart APP

Solution proposition

Fix: refactor VolumeStorageFactory to singleton - use it in services so it will use:
createIfDoesNotExist(path) method each time any storage is loaded.
@szymon-owczarzak szymon-owczarzak added the bug Something isn't working label Jan 22, 2020
@szymon-owczarzak szymon-owczarzak added this to the Major Bugs milestone Jan 22, 2020
@szymon-owczarzak szymon-owczarzak self-assigned this Feb 7, 2020
szymon-owczarzak added a commit that referenced this issue Feb 12, 2020
@szymon-owczarzak
#236 | Config not recreated after delete (#249)
1e93272 
* Configs will be recreated after deleting in runtime

* Unit Tests added for VolumeStorage

* BoardsConfigServiceTest test refactored and improved

* Adding 1-second delay after save is clicked - backend needs some time to save new config.
@szymon-owczarzak szymon-owczarzak removed their assignment Feb 12, 2020
@mpiotrowski1 mpiotrowski1 self-assigned this Feb 12, 2020
@mpiotrowski1
Copy link
Collaborator

Tested & accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpiotrowski1 mpiotrowski1

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@szymon-owczarzak @mpiotrowski1