Gulp migration #299
Gulp migration #299
Conversation
| @@ -15,8 +15,8 @@ | |||
| * See the License for the specific language governing permissions and | |||
| * limitations under the License. | |||
| */ | |||
| @import "compass"; | |||
| @import "../../node_modules/bootstrap-sass-twbs/assets/stylesheets/_bootstrap.scss"; | |||
| //@import "compass"; | |||
There was a problem hiding this comment.
Please remove this line if it's not needed
report/src/main/webapp/package.json
Outdated
| "matchdep": "^0.3.0", | ||
| "time-grunt": "^1.0.0" | ||
| "name": "aet", | ||
| "version": "2.1.16", |
There was a problem hiding this comment.
Why 2.1.16? Latest AET release is 2.1.6 and currently we have 2.1.7-SNAPSHOT on master branch
There was a problem hiding this comment.
Please update CHANGELOG according to AET Contributing rules
report/src/main/webapp/index.html
Outdated
|
|
||
| --> | ||
| <script> | ||
| (function(){ |
There was a problem hiding this comment.
This is not generic behaviour. There should be no such logic in the main index.htmlpage.
| @@ -0,0 +1,13796 @@ | |||
| { | |||
There was a problem hiding this comment.
This file looks like generated one. Do we need this here?
There was a problem hiding this comment.
Yes, my bad. Gonna get rid of it.
| // input[type=text] { |
There was a problem hiding this comment.
If this commented block doesn't affect any styling then please remove it
| // input[type=text] { |
There was a problem hiding this comment.
Could we just delete the lines if they are not needed?
.gitignore
Outdated
| # auto-generated css file | ||
| /report/src/main/webapp/assets/css | ||
| # auto-generated package-lock file | ||
| /report/src/main/webapp/package-lock.json |
There was a problem hiding this comment.
This file should be commited in my opinion.
Frontend maven plugin reports it as:
[ERROR] npm notice created a lockfile as package-lock.json. You should commit this file.
please consult i.e. @mateuszluczak
There was a problem hiding this comment.
If it should be commited, is it possible to make it smaller?
It had 13 000 lines.
There was a problem hiding this comment.
it should be commited, that's true, but I've never seen anywhere minified version of this file- I'd say, it won't hurt to put it as it is
Grunt changed to Gulp.
Description
App is now built using Gulp and because of that there is no need to install Ruby - we don't need Compass anymore. Refreshing after chaning SCSS/JS files is also much faster.
Motivation and Context
This change solves the issue with slow refresh/build times and it also gets rid of Compass.
User now can also go directly to localhost:9000 (by default) and he will be redirected to the report view, because I've added an index.html file.
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.