Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from setuptools_scm to setuptools-git-versioning #91

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

kjsanger
Copy link
Member

@kjsanger kjsanger commented Mar 9, 2023

setuptools has recently deprecated legacy versioning, so we moved to configuring setuptools_scm with the no-guess-dev option. It appears that a release always adds version bump in addition to the git tag.

e.g. release 1.0.1 reports its version as
1.0.1.post1.dev0+g3859438.d20230308

while 3859438 is the commit that was tagged on master as 1.0.1, the version has a post-release suffix (and appears to have been interpreted as a dev release?).

The issue reported here appears to be the same:
pypa/setuptools-scm#812

Trying setuptools-git-versioning instead in the hope that it is less "clever".

setuptools has recently deprecated legacy versioning, so we moved to
configuring setuptools_scm with the no-guess-dev option. It appears
that a release always adds version bump in addition to the git tag.

e.g. release 1.0.1 reports its version as
1.0.1.post1.dev0+g3859438.d20230308

while 3859438 is the commit that was tagged on master as 1.0.1, the
version has a post-release suffix (and appears to have been
interpreted as a dev release?).

The issue reported here appears to be the same:
pypa/setuptools-scm#812

Trying setuptools-git-versioning instead in the hope that it is less
"clever".
@kjsanger kjsanger merged commit b6c9ee2 into wtsi-npg:devel Mar 9, 2023
@kjsanger kjsanger deleted the feature/dynamic-version-capture branch March 9, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant