Bugfix: use annotate_results_collection to update metadata #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjsanger
force-pushed
the
bugfix/update-multiplexed-ont-metadata
branch
from
f15873c
to
3086d3c
Compare
The metadata update code path for ONT directly calls a lower level function which doesn't handle multiplexing, whereas is should call annotate_results_collection, which does. Added a test to cover this and improved some of the other tests.
kjsanger
force-pushed
the
bugfix/update-multiplexed-ont-metadata
branch
from
3086d3c
to
51c9fa5
Compare
marcomoscasgr
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metadata update code path for ONT directly calls a lower level function which doesn't handle multiplexing, whereas is should call annotate_results_collection, which does.