Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid argument requires capture on web #1

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Fix invalid argument requires capture on web #1

wants to merge 9 commits into from

Conversation

reginojohnrobert
Copy link
Collaborator

Added requires_capture enum on stripe_js
Updated pubspec.yaml of stripe_web
updateSettingsLazily set to true

Danielfelgate
Danielfelgate approved these changes Sep 24, 2023
View reviewed changes
Copy link

@Danielfelgate Danielfelgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice this looks all good 👍 Hopefully these issues can get resolved on the package relatively soon so we don't need to maintain this.

@BakerSmithA BakerSmithA mentioned this pull request Sep 26, 2023
Merged
karl-d
karl-d approved these changes Oct 17, 2023
View reviewed changes
Copy link

@karl-d karl-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the changes here, but guessing you have already made the required changes here for the application?

Also looks like they have merged the PR to fix this in the main package but not created a release yet.

@reginojohnrobert
Merge branch 'main' into fix-invalid-argument-requires-capture-on-web
97bdebf 
# Conflicts:
#	packages/stripe_js/lib/src/api/payment_intents/payment_intent_status.dart
#	packages/stripe_web/pubspec.yaml
@reginojohnrobert
Use stripe_js main package
6f2cc92
@reginojohnrobert
Merge pull request #4 from wt-health/main
008297e 
Get update from main branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karl-d karl-d karl-d approved these changes

@Danielfelgate Danielfelgate Danielfelgate approved these changes

@Matt-Web Matt-Web Awaiting requested review from Matt-Web

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reginojohnrobert @karl-d @Danielfelgate