[Choreo] Removal of unused internal service resource path named retrieve-api-artifacts and its usage #3639
+3
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtifacts and its usage
VirajSalaka
reviewed
Jan 22, 2025
| } else { | ||
| adapter.GetAPIs(c, nil, envs, sync.APIArtifactEndpoint, true, apiUUIDList, queryParamMap) | ||
| } | ||
| } else if conf.ControlPlane.DynamicEnvironments.Enabled { |
There was a problem hiding this comment.
We no longer need Dynamic Environments Enabled flag too.
There was a problem hiding this comment.
Config is used in multiple places. Since the issue -> https://github.com/wso2-enterprise/choreo/issues/31875
Is bit urgent shall we track removal of it with another task ?
There was a problem hiding this comment.
If we remove the code, wont the config get ignored or throw an error?
There was a problem hiding this comment.
You mean the cp-overlay config right ?
I'll not throw an error. But we'll have to clean up the repos if we remove the config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$subject
Relates with: https://github.com/wso2-enterprise/choreo/issues/31875
Issues
Fixes #
Automation tests
Tested environments
Not Tested
Maintainers: Check before merge