-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate tldts
to derive the domain
name
#7353
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7353 +/- ##
==========================================
+ Coverage 36.53% 41.98% +5.45%
==========================================
Files 42 42
Lines 906 936 +30
Branches 223 214 -9
==========================================
+ Hits 331 393 +62
+ Misses 555 543 -12
+ Partials 20 0 -20
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ceca40b
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
Purpose
This pull request includes several changes to improve the handling of domain extraction and cookie management across multiple components and files. The most important changes involve replacing custom domain extraction functions with a more robust utility function from the
tldts
library.Improvements to domain extraction:
apps/myaccount/src/components/footer/footer.tsx
: Replaced the customextractDomainFromHost
function withURLUtils.getDomain
for better domain parsing.apps/myaccount/src/components/shared/header.tsx
: Updated domain extraction in theHeader
component to useURLUtils.getDomain
.identity-apps-core/apps/authentication-portal/src/main/webapp/includes/footer.jsp
: Replaced the custom domain extraction logic withtldts.getDomain
for improved accuracy.modules/core/src/utils/url-utils.ts
: Added a new methodgetDomain
toURLUtils
that usestldts
for domain extraction.Library and dependency updates:
modules/core/package.json
: Added thetldts
library to the dependencies to support improved domain parsing.These changes ensure more reliable and accurate domain extraction across the application, improving cookie management and overall functionality.
Related Issues
Related PRs
Checklist
Security checks