-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix circular dependencies - Pt. 02 #7332
Open
pavinduLakshan
wants to merge
24
commits into
wso2:master
Choose a base branch
from
pavinduLakshan:fix_circular_deps_pt2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavinduLakshan
force-pushed
the
fix_circular_deps_pt2
branch
9 times, most recently
from
January 23, 2025 13:49
d4d363a
to
36017cf
Compare
pavinduLakshan
force-pushed
the
fix_circular_deps_pt2
branch
from
January 23, 2025 14:43
38ea973
to
9b7635e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7332 +/- ##
=======================================
Coverage 36.53% 36.53%
=======================================
Files 42 42
Lines 906 906
Branches 205 205
=======================================
Hits 331 331
Misses 575 575
Flags with carried forward coverage won't be shown. Click here to find out more. |
pavinduLakshan
force-pushed
the
fix_circular_deps_pt2
branch
from
January 26, 2025 05:50
646a61e
to
3f41cc3
Compare
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$subject
This PR removes index files from the admin.core.v1 and admin.user.v1 modules.
Circular dependency count:
Master branch:
Feature branch:
Related Issues
Related PRs
Checklist
Security checks