Move console related i18n extensions to @wso2is/i18n module
#7320
+743
−715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavinduLakshan
commented
Jan 18, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7320 +/- ##
=======================================
Coverage 36.04% 36.04%
=======================================
Files 42 42
Lines 899 899
Branches 205 222 +17
=======================================
Hits 324 324
Misses 575 575
Flags with carried forward coverage won't be shown. Click here to find out more. |
…ations to `@wso2is/i18n`
…ionRoles namespace
pavinduLakshan
force-pushed
the
move_console_i18n_extensions
branch
from
2862e0b to
67b921e
Compare
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
| @@ -112,11 +112,11 @@ export const ApplicationRolesList = (props: ApplicationRolesListProps): ReactEle | |||
| ) } | |||
| image={ getEmptyPlaceholderIllustrations().newList } | |||
| imageSize="tiny" | |||
| title={ t("extensions:console.applicationRoles.roleList.placeholder.title") } | |||
| title={ t("applicationRoles:roleList.placeholder.title") } | |||
There was a problem hiding this comment.
Let's update the copyright headers. Check other files as well.
|
Let's include the reason for this change in the PR description. This will serve as a reference for the refactoring in case any issues arise from moving it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
There are some i18n strings inside console/extensions folder. Since the console is now unified, we can move this i18n to i18n module to be used in both onprem and asgardeo.
This issue focuses on moving the i18n under "console" category[1] in console/extensions directory.
Related Issues
Related PRs
Checklist
Security checks