Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨: 認証のADRを追加 #531

Merged
merged 13 commits into from
Nov 5, 2021
Merged

✨: 認証のADRを追加 #531

merged 13 commits into from
Nov 5, 2021

Conversation

kozake
Copy link

@kozake kozake commented Nov 4, 2021

✅ What's done

  • 認証のADRを追加

⏸ What's not done

次の認証方式の技術検証については、方式設計以降に実施

  • Cookieはアプリ停止時に永続化情報から削除されるか
  • Known Issues with fetch and cookie based authenticationについての動作検証
  • 端末ロックを設定していない端末での端末ロックはどうなるか
  • KeyChainにログイン資格情報を保存する場合、どのようなセキュリティ設定が最適か

Tests

  • ローカル環境での表示確認

Other (messages to reviewers, concerns, etc.)

なし

@github-actions github-actions bot added the doc Improvements or additions to documentation label Nov 4, 2021
@kozake kozake requested a review from kz-takahashi November 4, 2021 05:01
Co-authored-by: takahashi <kz-takahashi@users.noreply.github.com>
kozake and others added 3 commits November 4, 2021 16:57
Co-authored-by: Ryo Tanaka <44867563+in-a-paddy@users.noreply.github.com>
Co-authored-by: Ryo Tanaka <44867563+in-a-paddy@users.noreply.github.com>
Co-authored-by: Ryo Tanaka <44867563+in-a-paddy@users.noreply.github.com>
@kozake kozake merged commit ad4fd34 into example-app-cycle1 Nov 5, 2021
@kozake kozake deleted the feature/auth-adr branch November 5, 2021 09:27
@in-a-paddy in-a-paddy removed their request for review November 5, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants