Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from lambda to titiler tiling for integrated alerts #179

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

solomon-negusse
Copy link
Member

@solomon-negusse solomon-negusse commented Nov 26, 2024

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the new behavior?

Adds fully dynamic tiling for Integrated Alerts with Titiler

Does this introduce a breaking change?

  • Yes
  • No

Other information

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.85%. Comparing base (8d79ee7) to head (3726ab5).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #179   +/-   ##
=======================================
  Coverage   79.85%   79.85%           
=======================================
  Files          61       61           
  Lines        2050     2050           
=======================================
  Hits         1637     1637           
  Misses        413      413           
Flag Coverage Δ
unittests 79.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@danscales danscales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Does it make sense at all to try to leave a route around for the old integrated alerts tile cache? I'm guessing not, since eventually we won't keep it up-to-date.

@gtempus gtempus changed the title swith from lambda to titiler tiling for integrated alerts switch from lambda to titiler tiling for integrated alerts Dec 2, 2024
Copy link
Contributor

@gtempus gtempus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to see us moving in the titiler direction, @solomon-negusse! Thanks for all the hard work on this! 💪

@jterry64 jterry64 merged commit 6021ddc into dev Dec 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants