-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dataset name; allow test datasets #173
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## staging #173 +/- ##
========================================
Coverage 79.85% 79.86%
========================================
Files 61 61
Lines 2050 2051 +1
========================================
+ Hits 1637 1638 +1
Misses 413 413
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! The alternative routing will be great for further testing of dist alerts.
@@ -455,6 +455,31 @@ resource "aws_cloudfront_distribution" "tiles" { | |||
} | |||
} | |||
|
|||
ordered_cache_behavior { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment at line 426 is confusing. Should that comment be here right above line 458, and the comment at line 426 should be "Send all cog requests to the tile cache app"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both are titiler endpoints. I have added clarifying comment for the DIST alerts one I just added and updated the generic one.
Thanks for the quick review, @danscales. |
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: the dist alerts endpoint has dataset name hardcoded and prevents visualizing test datasets
What is the new behavior?
Does this introduce a breaking change?
Other information