Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dataset name; allow test datasets #173

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

solomon-negusse
Copy link
Member

@solomon-negusse solomon-negusse commented Nov 8, 2024

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: the dist alerts endpoint has dataset name hardcoded and prevents visualizing test datasets

What is the new behavior?

  • Added flexibility to visualize test datasets

Does this introduce a breaking change?

  • Yes
  • No

Other information

@solomon-negusse solomon-negusse marked this pull request as draft November 8, 2024 18:01
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.86%. Comparing base (bd534de) to head (4a53264).

Files with missing lines Patch % Lines
app/routes/titiler/umd_glad_dist_alerts.py 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           staging     #173   +/-   ##
========================================
  Coverage    79.85%   79.86%           
========================================
  Files           61       61           
  Lines         2050     2051    +1     
========================================
+ Hits          1637     1638    +1     
  Misses         413      413           
Flag Coverage Δ
unittests 79.86% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@solomon-negusse solomon-negusse marked this pull request as ready for review November 10, 2024 05:45
@solomon-negusse solomon-negusse requested review from danscales, gtempus, dmannarino and manukala6 and removed request for danscales November 10, 2024 05:47
Copy link
Contributor

@danscales danscales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The alternative routing will be great for further testing of dist alerts.

@@ -455,6 +455,31 @@ resource "aws_cloudfront_distribution" "tiles" {
}
}

ordered_cache_behavior {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment at line 426 is confusing. Should that comment be here right above line 458, and the comment at line 426 should be "Send all cog requests to the tile cache app"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both are titiler endpoints. I have added clarifying comment for the DIST alerts one I just added and updated the generic one.

@solomon-negusse
Copy link
Member Author

Looks good! The alternative routing will be great for further testing of dist alerts.

Thanks for the quick review, @danscales.

@solomon-negusse solomon-negusse merged commit df7b40a into staging Nov 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants