Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default soiltype namelist option #2166

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

mathieulandreau
Copy link

Purpose: add a default_soiltype namelist option

TYPE: new feature

KEYWORDS: FEAT: Add a default_soiltype namelist option

SOURCE: Mathieu Landreau (Centrale Nantes)

DESCRIPTION OF CHANGES:
Problem:
When running real.exe, in the land cells where no soiltype is defined in the soil dataset, the type is set to 8=silty clay loam. For high-resolution coastal area simulation, this can represent a certain amount of cells.

Solution:
A namelist option named default_soiltype is added. It is checked (in module_check_a_mundo) that the user-defined value is between 1 and 19 and is not water (19)

LIST OF MODIFIED FILES: list of changed files (use git diff --name-status master to get formatted list)
Registry/Registry.EM_COMMON
dyn_em/module_initialize_real.F
run/README.namelist
share/module_check_a_mundo.F

TESTS CONDUCTED:
I realized this few month ago and didn't try again. It is possible to test with a coastal area case.

@mathieulandreau mathieulandreau requested review from a team as code owners February 11, 2025 14:41
@weiwangncar weiwangncar changed the base branch from master to develop February 11, 2025 16:20
@weiwangncar
Copy link
Collaborator

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants