Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): ✨ made CoreContactLink component #422

Merged
merged 6 commits into from
Nov 21, 2024
Merged

feat(core): ✨ made CoreContactLink component #422

merged 6 commits into from
Nov 21, 2024

Conversation

PritamBag
Copy link
Member

Description

Created a new CoreContactLink component to handle various contact types (email, phone, SMS, etc.).

  • Refactored CorePhoneLink and CoreEmailLink to utilize CoreContactLink internally.
  • Reduced code duplication and improved reusability for contact-related components.
  • Added support for configurable props such as variant, icon, and contact.

Ref: #421

Related Issues

Testing

Checklist

  • I have performed a thorough self-review of my code.
  • I have added or updated relevant tests for my changes.
  • My code follows the project's style guidelines and best practices.
  • I have updated the documentation if necessary.
  • I have added or updated relevant comments in my code.
  • I have resolved any merge conflicts of my branch.

Screenshots (if applicable)

Additional Notes

Reviewers

Maintainer Notes

  • Has this change been tested in a staging environment?
  • Does this change introduce any breaking changes or deprecations?

@PritamBag
feat(core): ✨ made CoreContactLink component
3ae6ea2 
unify CorePhoneLink and CoreEmailLink using CoreContactLink for reusability

Ref: #421
@PritamBag PritamBag added the enhancement New feature or request label Nov 18, 2024
@PritamBag PritamBag requested a review from techoneel November 18, 2024 07:04
@PritamBag PritamBag self-assigned this Nov 18, 2024
@PritamBag PritamBag linked an issue Nov 18, 2024 that may be closed by this pull request
enhancement: make CoreContactLink component #421
Closed
techoneel
techoneel approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@techoneel techoneel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go

@techoneel techoneel merged commit 66d12c8 into development Nov 21, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techoneel techoneel techoneel approved these changes

Assignees

@PritamBag PritamBag

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enhancement: make CoreContactLink component
2 participants
@PritamBag @techoneel