Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): ✨ alt props text CoreImage #287

Merged
merged 1 commit into from
Aug 16, 2024
Merged

feat(core): ✨ alt props text CoreImage #287

merged 1 commit into from
Aug 16, 2024

Conversation

anantakumarghosh
Copy link
Member

@anantakumarghosh anantakumarghosh commented Aug 16, 2024 •
edited
Loading

Description

This PR adds support for alt props text in CoreImage component".

Related Issues

Testing

Checklist

  • I have performed a thorough self-review of my code.
  • I have added or updated relevant tests for my changes.
  • My code follows the project's style guidelines and best practices.
  • I have updated the documentation if necessary.
  • I have added or updated relevant comments in my code.
  • I have resolved any merge conflicts of my branch.

Screenshots (if applicable)

Additional Notes

Reviewers

Maintainer Notes

  • Has this change been tested in a staging environment?
  • Does this change introduce any breaking changes or deprecations?

@anantakumarghosh anantakumarghosh self-assigned this Aug 16, 2024
@anantakumarghosh anantakumarghosh added the enhancement New feature or request label Aug 16, 2024
@anantakumarghosh
feat(core): ✨ alt text CoreImage
c315f56 
add alt text in CoreImage component, wrappid/guide-module#186

Ref: #286
techoneel
techoneel reviewed Aug 16, 2024
View reviewed changes
Copy link
Member

@techoneel techoneel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need clarifications

techoneel
techoneel approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@techoneel techoneel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go

@anantakumarghosh anantakumarghosh merged commit a29a15b into development Aug 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techoneel techoneel techoneel approved these changes

Assignees

@anantakumarghosh anantakumarghosh

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anantakumarghosh @techoneel