Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): ✨ adding new props and varient #285

Merged
merged 1 commit into from
Aug 16, 2024
Merged

feat(core): ✨ adding new props and varient #285

merged 1 commit into from
Aug 16, 2024

Conversation

arkaprota
Copy link
Member

Description

varient props is added to verify listType is going to work or not

<CoreList varient="HTML" listType="AUTO">
      <CoreListItems>
              <CoreListItemsText primary="Enter your text"> 
      <CoreListItems>
<CoreList>

Ref: #284

@arkaprota
feat(core): ✨ adding new props and varient
6cb0a1d 
varient props is added to verify listType is going to work or not

Ref: #284
@arkaprota arkaprota added enhancement New feature or request requirement-proposed This is a new proposed feature labels Aug 14, 2024
@arkaprota arkaprota requested a review from techoneel August 14, 2024 13:21
@arkaprota arkaprota self-assigned this Aug 14, 2024
techoneel
techoneel requested changes Aug 14, 2024
View reviewed changes
Copy link
Member

@techoneel techoneel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the props name because the variant prop is used by the mui library.

@arkaprota
Copy link
Member Author

arkaprota commented Aug 14, 2024 •
edited
Loading

can you suggest me some name that can be used
@techoneel

@techoneel
Copy link
Member

can you suggest me some name that can be used
@techoneel

htmlVariant the value can be Boolean default false.

@anantakumarghosh
Copy link
Member

After making changes, please re-request for review @arkaprota

@wrappidcare
Copy link
Contributor

Merging since stale over 24hrs.

@wrappidcare wrappidcare merged commit c247542 into development Aug 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techoneel techoneel techoneel requested changes

Assignees

@arkaprota arkaprota

Labels
enhancement New feature or request requirement-proposed This is a new proposed feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arkaprota @techoneel @anantakumarghosh @wrappidcare