Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): 🐛 core appbar margin-top bug fixed #199

Merged
merged 1 commit into from
Apr 6, 2024
Merged

fix(core): 🐛 core appbar margin-top bug fixed #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package/styles/DefaultCoreStyles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { DefaultUtilityStyles, DEFAULT_PADDING, PX_TAG, IMPORTANT, BaseStyle } f
/**
* @todo: have to calculate manually nav height varying depending on screen size
*/
const HEADING_TOP_MARGIN = "56px";
const HEADING_TOP_MARGIN = "64px";

export const DEFAULT_SPACING = 1;

Expand Down
4 changes: 3 additions & 1 deletion package/styles/MediumCoreStyles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {

// -- const MIN_WIDTH = MEDIUM_WINDOW_WIDTH;
// -- const MAX_WIDTH = LARGE_WINDOW_WIDTH - 1;
// -- const HEADING_TOP_MARGIN = "64px";
// const HEADING_TOP_MARGIN = "64px";

export default class MediumCoreStyles extends BaseStyle {
mediumUtilityStyles = new MediumUtilityStyles().style;
Expand All @@ -24,6 +24,8 @@ export default class MediumCoreStyles extends BaseStyle {
appBarLogo: {},

auditData: {},

contentContainer: {},

dataTable: {
...new DefaultUtilityStyles().style.mtN1,
Expand Down
2 changes: 1 addition & 1 deletion package/styles/SmallCoreStyles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export default class SmallCoreStyles extends BaseStyle {
appbarHeight : { top: HEADING_TOP_MARGIN + IMPORTANT },
auditData : {},

contentContainer: { marginTop: HEADING_TOP_MARGIN + IMPORTANT },
contentContainer: {},

dataTable: {
...new DefaultUtilityStyles().style.mtN1,
Expand Down
Loading