-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSO Integration #8
Comments
- Markdown File: https://github.com/websharks/comment-mail-kb/blob/master/tutorials/2015/8-sso-integration.md - Published KB Article: http://comment-mail.com/kb-article/sso-integration/
@jaswsinc: Love this article! I followed the instructions but I noticed that there was one missing step for the Facebook SSO integration. Missing step for Facebook SSO Integration article Step 6: Add Callback URLClick on the Advanced Tab and look for the OAuth settings section. You will be asked for a Callback URL, which you can obtain from your Comment Mail™ installation via the WP Dashboard. |
@kristineds writes...
Did you find this was necessary in order to complete the integration? I'm curious to know if you had trouble getting this to work without that step, because as far as I know, this is not absolutely necessary; i.e., you can leave this blank and still be OK. |
Agree. It works fine without it. i.e. I can still log in using my FB account to reply to the comment. But I saw that note on the field, warning users on the app being open to redirect attacks, that's why I added it. If it is unnecessary, then we could just go ahead and skip this step. :) |
Copy that. Thank you. I will leave this open. I think setting this up is a very good idea, even though it is technically unnecessary. In the article we can add a section that explains what these redirects do and offer the suggestion that you should set this up for each of the SSO services at some point later. |
Noting that in most cases, setting the oAuth redirect URI to the root domain of your site is enough to prevent the possibility of anything out of the ordinary; e.g., setting the redirect URI to: |
@jaswsinc @raamdev : The screenshots provided on the tutorial for Google SSO Integration needs to be updated as the UI on the Google Developer Console dashboard has been changed recently and this might be confusing for our customers. NOTE: The KB article has been updated with these changes. http://comment-mail.com/kb-article/sso-integration/ |
@kristineds Reviewed. Thank you for updating that! :-) TODO@jaswsinc writes ↑ in #8 (comment)...
|
Status April 2018: Google SSO works, Twitter and Facebook cannot get to work though. Facebook: We spent another entire day trying to solve facebook sso, but not working. Hours after hours of wading through possible solutions on google, trying again all suggested combinations of settings, but nothing got working. Any chance Kristine or Jason could rework this kb page? https://comment-mail.com/kb-article/sso-integration/ |
I feel I should add another helpful feedback: So my second suggestion on this matter: Allowing CommentMail Plus customers to enter the actual comment form location where to return the user to. The generic commentmail return link, say for google, https://example.com/?comment_mail%5Bsso%5D%5Bservice%5D=google&comment_mail%5Bsso%5D%5Baction%5D=callback -- |
Before I forget it: wpsharks/comment-mail#199 It seems Jason hasn't looked at Raam's (and 90% of all customers') feature request yet, still? So we went ahead and after all those years of waiting implemented sso nonetheless, see my 2 contributions above.
Of course, there's no way to add thousands of page urls to fb's field "Valid OAuth Redirect URIs"...
Their wording "using ONLY the facebook sdk" seems critical: I tried using their login button code, but it returns the same error as before ("") because I was now using the sdk AND commentmail's fb integration still in the background (which I wouldn't know how to cancel). I hope all this helps, but I am there if you need more information. |
KB Article Creation Checklist
draft
and eitherquestions
ortutorials
draft
label, adddraft-finalized
label)draft-finalized
label, addpending
)pending
label, addpublished
label)Additional TODOs
Additional TODO list items go here.
View Markdown File | ✏️ Edit Markdown File
📃 Published KB Article: http://comment-mail.com/kb-article/sso-integration/
The text was updated successfully, but these errors were encountered: