Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document vendordep gradle task #755

Merged
merged 8 commits into from
Oct 23, 2020
Merged

Conversation

Starlight220
Copy link
Member

Accompanies wpilibsuite/GradleRIO#418.
Draft until the above commit is merged.

@Starlight220
Copy link
Member Author

@Daltz333 , can you mark this as ready for review and Waiting on dependency?

@Starlight220 Starlight220 marked this pull request as ready for review July 6, 2020 12:37
@Daltz333
Copy link
Member

Can you merge master?

@Starlight220
Copy link
Member Author

Won't merge add the 40 commits to this PR? If so, was there a problem with the rebase?

@Starlight220
Copy link
Member Author

Anyway, this is waiting on wpilibsuite/GradleRIO#418 so it isn't going anywhere and will probably need to be updated then. Can you mark this as Waiting on: Dependency/WPILib?

@Daltz333 Daltz333 added the Waiting On: WPILib Waiting on something from WPILib label Aug 27, 2020
@Daltz333 Daltz333 removed the Waiting On: WPILib Waiting on something from WPILib label Oct 17, 2020
@Daltz333
Copy link
Member

Daltz333 commented Oct 17, 2020

Could you merge or rebase onto master?

@Starlight220
Copy link
Member Author

@ThadHouse can you make sure I haven't made any technical mistakes in the docs?

@Starlight220
Copy link
Member Author

I haven't noticed that the whole article had been reworked. Maybe the section I'm adding should be added somewhere/somehow else in the article?

@Daltz333
Copy link
Member

The article hasn't been reworked, just moved around. I'm fine with merging this mostly as is (see my comment), as I can just incorporate the information into a revision later. My goal is to better integrate using CAN devices into the zero-to-robot as that's what the overwhelming majority of teams use as their main motor controllers.

Co-authored-by: Dalton Smith <daltzsmith@gmail.com>
Co-authored-by: Dalton Smith <daltzsmith@gmail.com>
@Daltz333 Daltz333 merged commit 86f10d4 into wpilibsuite:master Oct 23, 2020
@Starlight220 Starlight220 deleted the patch-1 branch October 24, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants