Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fieldImages] Use rendered image #7650

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

PeterJohnson
Copy link
Member

@PeterJohnson PeterJohnson commented Jan 7, 2025

@PeterJohnson PeterJohnson requested a review from a team as a code owner January 7, 2025 01:01
@sciencewhiz
Copy link
Contributor

Glass doesn't like the field border

image

@sciencewhiz
Copy link
Contributor

This works for me

    "top-left": [
      534,
      291
    ],
    "bottom-right": [
      3466,
      1638
    ]

image

@sciencewhiz
Copy link
Contributor

It looks like Elastic uses a cropped version of the image, which is why the corners don't line up

image

@PeterJohnson
Copy link
Member Author

Fixed the corners, thanks!

@PeterJohnson PeterJohnson merged commit 58d7c07 into wpilibsuite:main Jan 7, 2025
47 checks passed
@PeterJohnson PeterJohnson deleted the field-image-update branch January 7, 2025 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants