Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ntcore] Various cleanups #7216

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
67da78a
[ntcore] LocalStorage: Move template functions inside class definition
PeterJohnson Oct 15, 2024
4d48b28
[ntcore] Value: Inline constructors
PeterJohnson Oct 15, 2024
4d362be
[ntcore] NetworkOutgoingQueue: Move function defs inside class
PeterJohnson Oct 15, 2024
5ec504e
[ntcore] Move ServerImpl to nt::server namespace
PeterJohnson Oct 16, 2024
7ba660c
[ntcore] Move ServerImpl detail classes to separate files
PeterJohnson Oct 16, 2024
dad9dd1
[ntcore] Move ServerImpl.m_local to ServerClientLocal
PeterJohnson Oct 16, 2024
70a336a
[ntcore] Store client name instead of pointer in server pub/sub
PeterJohnson Oct 16, 2024
2065416
[ntcore] Make server publisher and subscriber classes
PeterJohnson Oct 16, 2024
39d75b9
[ntcore] Server: remove unused m_controlReady
PeterJohnson Oct 16, 2024
c08be9e
[ntcore] Split ServerStorage out from ServerImpl
PeterJohnson Oct 17, 2024
9c2c8fe
[ntcore] ServerImpl: Move some creation to ServerClient4
PeterJohnson Oct 17, 2024
98a1a4b
[ntcore] ServerImpl: Refactor getting empty client slot
PeterJohnson Oct 17, 2024
fc437ec
[ntcore] ServerImpl: Inlining
PeterJohnson Oct 17, 2024
03ac7a3
[ntcore] Move metatopic creation from SetLocal to constructor
PeterJohnson Oct 17, 2024
7cda974
Clean up some forward declarations
PeterJohnson Oct 17, 2024
4941ab4
[ntcore] Split LocalStorage implementation into separate files
PeterJohnson Oct 19, 2024
db106cc
[ntcore] LocalStorage: Change GetEntry to return Entry
PeterJohnson Oct 19, 2024
337bc1c
[ntcore] LocalStorage: Rename classes to Local*
PeterJohnson Oct 19, 2024
a215d89
[ntcore] LocalStorageImpl: Replace WPI_ERROR with ERR
PeterJohnson Oct 19, 2024
8fa4bcd
[ntcore] HandleMap: Use concepts for T
PeterJohnson Oct 19, 2024
f8888c8
[ntcore] Refactor local topic DataLog
PeterJohnson Oct 19, 2024
85ba06e
[ntcore] Move properties and flags refresh to LocalTopic
PeterJohnson Oct 19, 2024
2285fc1
[ntcore] Further refactor of topic datalog
PeterJohnson Oct 19, 2024
ba95c44
[ntcore] Local topic: Refactor flags
PeterJohnson Oct 20, 2024
9a6ef9f
[ntcore] Local topic: A bit more properties refactor
PeterJohnson Oct 20, 2024
207df78
[ntcore] Use Endian.h in WireEncoder3
PeterJohnson Oct 22, 2024
91677f3
[ntcore] ServerStorage: Fix includes
PeterJohnson Oct 22, 2024
866fe1b
[ntcore] LocalDataLoggerEntry: Add missing includes
PeterJohnson Oct 22, 2024
92e0fb7
[ntcore] LocalSubscriber: Add missing include
PeterJohnson Oct 22, 2024
ec5098e
[ntcore] LocalStorageImpl: Add missing includes
PeterJohnson Oct 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ntcore/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,11 @@ file(
GLOB ntcore_native_src
src/main/native/cpp/*.cpp
src/generated/main/native/cpp/*.cpp
src/main/native/cpp/local/*.cpp
src/main/native/cpp/net/*.cpp
src/main/native/cpp/net3/*.cpp
src/main/native/cpp/networktables/*.cpp
src/main/native/cpp/server/*.cpp
src/main/native/cpp/tables/*.cpp
)
add_library(ntcore ${ntcore_native_src})
Expand Down
8 changes: 7 additions & 1 deletion ntcore/src/main/native/cpp/HandleMap.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

#pragma once

#include <concepts>
#include <memory>
#include <utility>

Expand All @@ -13,8 +14,13 @@

namespace nt {

template <typename T>
concept HandleType = requires {
{ T::kType } -> std::convertible_to<NT_Handle>;
};

// Utility wrapper class for our UidVectors
template <typename T, size_t Size>
template <HandleType T, size_t Size>
class HandleMap : public wpi::UidVector<std::unique_ptr<T>, Size> {
public:
template <typename... Args>
Expand Down
Loading
Loading