Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sysid] Remove unused dependency on libglassnt #7200

Merged
merged 2 commits into from
Oct 12, 2024

Conversation

Gold856
Copy link
Contributor

@Gold856 Gold856 commented Oct 12, 2024

No description provided.

@Gold856 Gold856 requested a review from a team as a code owner October 12, 2024 04:34
PeterJohnson
PeterJohnson previously approved these changes Oct 12, 2024
@PeterJohnson
Copy link
Member

It needs a wpinet dependency added to get libuv.

@Gold856
Copy link
Contributor Author

Gold856 commented Oct 12, 2024

Does it actually use libuv? I'm not finding any instances of the uv namespace in any SysId code.

@PeterJohnson
Copy link
Member

PeterJohnson commented Oct 12, 2024

from the cmake CI build:

/__w/allwpilib/allwpilib/sysid/src/main/native/cpp/App.cpp:22:10: fatal error: uv.h: No such file or directory
   22 | #include <uv.h>
      |          ^~~~~~
compilation terminated.

But maybe that's a copypasta from a different tool and can simply be removed (along with the call to uv_os_setenv)?

@Gold856
Copy link
Contributor Author

Gold856 commented Oct 12, 2024

Weirdly enough, there's no other call to uv_os_setenv anywhere in the monorepo. I wonder if this is leftover from when SysId used to deploy it's own project and connected with NT.

@Gold856
Copy link
Contributor Author

Gold856 commented Oct 12, 2024

Looks like this SysId commit added it as part of the deploy infrastructure. So this is, in fact, leftover from the project deployment days.

@PeterJohnson PeterJohnson merged commit f23bece into wpilibsuite:main Oct 12, 2024
33 checks passed
@Gold856 Gold856 deleted the remove-unused-sysid-dependency branch October 12, 2024 05:20
katzuv pushed a commit to katzuv/allwpilib that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants