Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sysid] Fix crash when all data is filtered out during analysis #7199

Merged
merged 2 commits into from
Oct 12, 2024

Conversation

Gold856
Copy link
Contributor

@Gold856 Gold856 commented Oct 12, 2024

Fixes #6438.

Here's what the error screen looks like when trying to load the log in the issue:
image
A bunch of the UI elements aren't present, but I think that's fine here since analysis isn't possible. The plot in the background is from a previous analysis.

@Gold856 Gold856 requested a review from a team as a code owner October 12, 2024 04:31
Co-authored-by: Peter Johnson <johnson.peter@gmail.com>
@PeterJohnson PeterJohnson merged commit 7ebd45e into wpilibsuite:main Oct 12, 2024
33 checks passed
@Gold856 Gold856 deleted the sysid-crash-fix branch October 12, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sysid crashes when all data is filtered out during analysis
2 participants