[ntcore] Change internal interfaces and messages to use UIDs #7189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterJohnson
added a commit
that referenced
this pull request
Oct 12, 2024
The changes in #7189 caused an ambiguity between multi-subscribers and normal subscribers, because the handle type no longer is sent to the network. Multi-subscribers now go to the network with negative UIDs, normal subscribers are positive UIDs. UID 0 is never used.
katzuv
pushed a commit
to katzuv/allwpilib
that referenced
this pull request
Oct 14, 2024
…uite#7189) Also make Handle functions constexpr.
katzuv
pushed a commit
to katzuv/allwpilib
that referenced
this pull request
Oct 14, 2024
…suite#7198) The changes in wpilibsuite#7189 caused an ambiguity between multi-subscribers and normal subscribers, because the handle type no longer is sent to the network. Multi-subscribers now go to the network with negative UIDs, normal subscribers are positive UIDs. UID 0 is never used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make Handle functions constexpr.