Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmd] Add Scheduled command decorator #7083

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

narmstro2020
Copy link
Contributor

This seemed to be missing as most of the other commands have a decorator.

I'm struggling a bit with the C++

@narmstro2020 narmstro2020 requested a review from a team as a code owner September 15, 2024 03:03
Copy link
Contributor

This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR.

@narmstro2020 narmstro2020 changed the title [WPICommand] Add Scheduled command decorator [wpilibNewCommands] Add Scheduled command decorator Sep 15, 2024
@narmstro2020
Copy link
Contributor Author

/format

@narmstro2020
Copy link
Contributor Author

/format

@narmstro2020
Copy link
Contributor Author

/format

@narmstro2020
Copy link
Contributor Author

/format

@calcmogul calcmogul changed the title [wpilibNewCommands] Add Scheduled command decorator [cmd] Add Scheduled command decorator Sep 16, 2024
@narmstro2020
Copy link
Contributor Author

How is this one looking?

@spacey-sooty
Copy link
Contributor

spacey-sooty commented Oct 11, 2024

How is this one looking?

it doesn't have C++, do you need help with that? It also needs a Python implementation

@narmstro2020
Copy link
Contributor Author

How is this one looking?

it doesn't have C++, do you need help with that? It also needs a Python implementation

Sorry I should've specified a little more.

I need a wee bit of help with the C++, I made a go at it in another PR, but had to pull back and wait for some help.

Also I have a Python implementation already posted.

@narmstro2020
Copy link
Contributor Author

@spacey-sooty
This is the attempt I have for the c++ so far

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants