-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cmd] Deprecate Command.schedule() #7072
Open
Gold856
wants to merge
4
commits into
wpilibsuite:main
Choose a base branch
from
Gold856:deprecate-command-schedule
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+77
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR. |
Usages (such as Trigger) need to be updated |
Gold856
force-pushed
the
deprecate-command-schedule
branch
from
September 17, 2024 23:55
80686e6
to
8c8d94d
Compare
wpilibNewCommands/src/test/native/cpp/frc2/command/CommandSendableButtonTest.cpp
Outdated
Show resolved
Hide resolved
Gold856
force-pushed
the
deprecate-command-schedule
branch
from
September 18, 2024 06:11
83cac71
to
dcc9044
Compare
spacey-sooty
suggested changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
armbot needs update
Waiting on #7054 to remove it. |
Gold856
force-pushed
the
deprecate-command-schedule
branch
4 times, most recently
from
October 12, 2024 22:25
92359e0
to
1a1552f
Compare
It's a footgun and syntactic sugar over the CommandScheduler's schedule method. We don't need syntactic sugar for a footgun.
…ableButtonTest.cpp Co-authored-by: Starlight220 <53231611+Starlight220@users.noreply.github.com>
Gold856
force-pushed
the
deprecate-command-schedule
branch
from
October 18, 2024 12:48
1a1552f
to
3f6f458
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a footgun and syntactic sugar over the CommandScheduler's schedule method. We don't need syntactic sugar for a footgun.