[hal] Check for invalid handle before closing handles #7016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crossConnIntegrationTests/src/main/native/include/LifetimeWrappers.h
Outdated
Show resolved
Hide resolved
auscompgeek
reviewed
Aug 31, 2024
If the function used the status parameter, it now logs an error.
PeterJohnson
approved these changes
Sep 7, 2024
rzblue
added a commit
to rzblue/allwpilib
that referenced
this pull request
Oct 16, 2024
This was overlooked by mistake in wpilibsuite#7016
rzblue
added a commit
to rzblue/allwpilib
that referenced
this pull request
Oct 16, 2024
This was overlooked by mistake in wpilibsuite#7016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6991
Adds a close function pointer template parameter to
hal::Handle- this allowed default destructors in many places.The status parameter has been removed from close functions- in most places it was not used. Where it was, an error is printed in stead.
JNI functions also check for invalid handle- though now that i'm thining about it, I'm not sure this is really necessary. It's easy enough to remove.