Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] CMake: Fix find_package(wpilib) calls when some libraries are missing #6784

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

Gold856
Copy link
Contributor

@Gold856 Gold856 commented Jun 28, 2024

Calling find_package(wpilib) often fails when a library like wpilibc is not built and installed. This is because the *_DEP_REPLACE variables filled in wpilib-config.cmake with find_dependency calls to libraries that weren't built. The *_DEP_REPLACE variables have been moved to make it less error-prone by adding a library and setting its variable in the same block.

@Gold856 Gold856 requested a review from a team as a code owner June 28, 2024 23:00
@PeterJohnson PeterJohnson merged commit c3c1671 into wpilibsuite:main Jun 29, 2024
29 of 30 checks passed
@Gold856 Gold856 deleted the cmake-find-package-fix branch June 29, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants