Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix robotpy PR commenting for real this time #6723

Merged
merged 1 commit into from
Jun 9, 2024
Merged

Fix robotpy PR commenting for real this time #6723

merged 1 commit into from
Jun 9, 2024

Conversation

Gold856
Copy link
Contributor

@Gold856 Gold856 commented Jun 9, 2024 •
edited
Loading

The docs say that GITHUB_TOKEN will be given write permissions when using pull_request_target. Using pull_request means the permissions will be read-only.

@Gold856 Gold856 requested a review from a team as a code owner June 9, 2024 04:44
@PeterJohnson
Copy link
Member

This removes the GitHub-token? Is one provided by default?

@Gold856
Copy link
Contributor Author

Gold856 commented Jun 9, 2024 •
edited
Loading

Yes, one is provided by default.

@auscompgeek
Copy link
Member

Yeah, actions within @actions have special privilege to receive github.token as a default.

@PeterJohnson PeterJohnson merged commit b9935c9 into wpilibsuite:main Jun 9, 2024
28 of 29 checks passed
@Gold856 Gold856 deleted the test branch June 9, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auscompgeek auscompgeek auscompgeek approved these changes

@PeterJohnson PeterJohnson PeterJohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gold856 @PeterJohnson @auscompgeek