Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hal] Fix interrupt edges being flipped in sim #6720

Merged
merged 2 commits into from
Jul 17, 2024
Merged

[hal] Fix interrupt edges being flipped in sim #6720

merged 2 commits into from
Jul 17, 2024

Conversation

Gold856
Copy link
Contributor

@Gold856 Gold856 commented Jun 9, 2024 •
edited
Loading

Fixes #6440, fixes #6515. Replaces #6688.

@Gold856 Gold856 requested review from a team as code owners June 9, 2024 03:24
KangarooKoala
KangarooKoala reviewed Jun 9, 2024
View reviewed changes
Copy link
Contributor

@KangarooKoala KangarooKoala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, C++ tests have a 20 millisecond wait between enabling the interrupt and setting the value, while the Java tests have a 10 millisecond (0.01 second) wait. It's probably fine, but it'd be nice if they were the same.

wpilibc/src/test/native/cpp/InterruptTest.cpp Outdated Show resolved Hide resolved
wpilibj/src/test/java/edu/wpi/first/wpilibj/InterruptTest.java Outdated Show resolved Hide resolved
wpilibj/src/test/java/edu/wpi/first/wpilibj/InterruptTest.java Outdated Show resolved Hide resolved
@Gold856 Gold856 force-pushed the sim-interrupt-fix branch 2 times, most recently from de62a75 to 71ea41b Compare June 22, 2024 04:06
@PeterJohnson PeterJohnson merged commit e5b7cf4 into wpilibsuite:main Jul 17, 2024
33 checks passed
@Gold856 Gold856 deleted the sim-interrupt-fix branch July 17, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KangarooKoala KangarooKoala KangarooKoala left review comments

@PeterJohnson PeterJohnson PeterJohnson approved these changes

@ThadHouse ThadHouse Awaiting requested review from ThadHouse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Gold856 @PeterJohnson @KangarooKoala