[wpimath] Disambiguate wpimath JNI functions #6695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calcmogul
force-pushed
the
wpimath-disambiguate-wpimath-jni-functions
branch
from
d5c7b27
to
0fec466
Compare
PeterJohnson
reviewed
Jun 3, 2024
calcmogul
force-pushed
the
wpimath-disambiguate-wpimath-jni-functions
branch
2 times, most recently
from
5b11002
to
9f545c8
Compare
sciencewhiz
added a commit
to sciencewhiz/PathWeaver
that referenced
this pull request
Jun 4, 2024
Now, each collection of JNI functions has its own class.
calcmogul
force-pushed
the
wpimath-disambiguate-wpimath-jni-functions
branch
from
9f545c8
to
1920365
Compare
PeterJohnson
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, each collection of JNI functions is namespaced within a static class.