Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sysid] Fix crash on negative feedforward gains #6425

Merged
merged 1 commit into from
Mar 11, 2024
Merged

[sysid] Fix crash on negative feedforward gains #6425

merged 1 commit into from
Mar 11, 2024

Commits on Mar 9, 2024

  1. [sysid] Fix crash on negative feedforward gains 

    LinearSystemId's linear system factories throw on negative feedforward
gains, but SysId can compute the feedback gains just fine in that case.
Now we construct the system manually instead.

Fixes wpilibsuite#6423.
    @calcmogul
    calcmogul committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    967dd14 View commit details
    Browse the repository at this point in the history