-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[examples] Call resetOdometry() when controller command is executed #5905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzblue
requested changes
Nov 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C++ also should have comments added/revised as in the Java version
wpilibcExamples/src/main/cpp/examples/MecanumControllerCommand/cpp/RobotContainer.cpp
Show resolved
Hide resolved
wpilibcExamples/src/main/cpp/examples/RamseteCommand/cpp/RobotContainer.cpp
Outdated
Show resolved
Hide resolved
wpilibcExamples/src/main/cpp/examples/RamseteCommand/cpp/RobotContainer.cpp
Outdated
Show resolved
Hide resolved
...es/src/main/java/edu/wpi/first/wpilibj/examples/mecanumcontrollercommand/RobotContainer.java
Outdated
Show resolved
Hide resolved
wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/ramsetecommand/RobotContainer.java
Outdated
Show resolved
Hide resolved
rzblue
requested changes
Nov 13, 2023
wpilibcExamples/src/main/cpp/examples/RamseteCommand/cpp/RobotContainer.cpp
Outdated
Show resolved
Hide resolved
Starlight220
requested changes
Nov 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applies to all files:
- "Run" in the comments should be lowercase
- Each Java/C++ should be internally consistent on how it instantiates commands: calling the factory methods or calling the classes directly. Each example doesn't have to do it all the same way, but it should be consistent between languages (ie don't call InstantCommand directly in C++ in a place where Java calls runOnce)
...es/src/main/java/edu/wpi/first/wpilibj/examples/mecanumcontrollercommand/RobotContainer.java
Outdated
Show resolved
Hide resolved
wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/ramsetecommand/RobotContainer.java
Outdated
Show resolved
Hide resolved
...les/src/main/java/edu/wpi/first/wpilibj/examples/swervecontrollercommand/RobotContainer.java
Outdated
Show resolved
Hide resolved
wpilibcExamples/src/main/cpp/examples/MecanumControllerCommand/cpp/RobotContainer.cpp
Outdated
Show resolved
Hide resolved
wpilibcExamples/src/main/cpp/examples/MecanumControllerCommand/cpp/RobotContainer.cpp
Outdated
Show resolved
Hide resolved
wpilibcExamples/src/main/cpp/examples/SwerveControllerCommand/cpp/RobotContainer.cpp
Outdated
Show resolved
Hide resolved
…groups. Made sure to keep examples consistent between c++ and java
Starlight220
previously approved these changes
Nov 27, 2023
rzblue
previously requested changes
Dec 1, 2023
...es/src/main/java/edu/wpi/first/wpilibj/examples/mecanumcontrollercommand/RobotContainer.java
Outdated
Show resolved
Hide resolved
wpilibcExamples/src/main/cpp/examples/SwerveControllerCommand/cpp/RobotContainer.cpp
Outdated
Show resolved
Hide resolved
wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/ramsetecommand/RobotContainer.java
Outdated
Show resolved
Hide resolved
...les/src/main/java/edu/wpi/first/wpilibj/examples/swervecontrollercommand/RobotContainer.java
Outdated
Show resolved
Hide resolved
calcmogul
changed the title
called resetOdometry() when controllercommand is executed
[examples] Call resetOdometry() when controller command is executed
Dec 1, 2023
Needs to be rebased and conflicts resolved. |
Starlight220
previously approved these changes
Dec 5, 2023
calcmogul
approved these changes
Dec 7, 2023
Starlight220
approved these changes
Dec 7, 2023
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5884