Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Call resetOdometry() when controller command is executed #5905

Merged
merged 17 commits into from
Dec 7, 2023
Merged

[examples] Call resetOdometry() when controller command is executed #5905

merged 17 commits into from
Dec 7, 2023

Conversation

ElliotScher
Copy link
Contributor

closes #5884

@ElliotScher ElliotScher requested review from a team as code owners November 10, 2023 19:42
Copy link
Member

@rzblue rzblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C++ also should have comments added/revised as in the Java version

Copy link
Member

@Starlight220 Starlight220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applies to all files:

  • "Run" in the comments should be lowercase
  • Each Java/C++ should be internally consistent on how it instantiates commands: calling the factory methods or calling the classes directly. Each example doesn't have to do it all the same way, but it should be consistent between languages (ie don't call InstantCommand directly in C++ in a place where Java calls runOnce)

Starlight220
Starlight220 previously approved these changes Nov 27, 2023
@calcmogul calcmogul changed the title called resetOdometry() when controllercommand is executed [examples] Call resetOdometry() when controller command is executed Dec 1, 2023
@Starlight220
Copy link
Member

Needs to be rebased and conflicts resolved.

@ElliotScher ElliotScher closed this Dec 5, 2023
Starlight220
Starlight220 previously approved these changes Dec 5, 2023
@PeterJohnson PeterJohnson merged commit 39a0bf4 into wpilibsuite:main Dec 7, 2023
25 checks passed
@gartaud
Copy link

gartaud commented Dec 8, 2023

Thanks!

@ElliotScher ElliotScher deleted the 5884 branch December 13, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants