Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove periodic can read call #1868

Merged
merged 3 commits into from
Sep 28, 2019
Merged

Remove periodic can read call #1868

merged 3 commits into from
Sep 28, 2019

Conversation

ThadHouse
Copy link
Member

It is not necessary anymore, and is a complicated and confusing API to keep around

@ThadHouse
Remove periodic can read call
2916629 
It is not necessary anymore, and is a complicated and confusing API to keep around
@ThadHouse
Remove periodic calls from pdp
cfe331b
@ThadHouse
formatting
8507feb
@PeterJohnson PeterJohnson merged commit 8858ec5 into wpilibsuite:master Sep 28, 2019
@rzblue rzblue mentioned this pull request Jul 27, 2024
Merged
PeterJohnson pushed a commit that referenced this pull request Jul 27, 2024
@rzblue
[hal] Remove dangling periodic packet function from sim CANAPI (NFC) (#…
81ec66f 
…6879)

Removed from API in #1868, sim definition was left dangling.

Also adds extern "C" to the sim file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterJohnson PeterJohnson PeterJohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThadHouse @PeterJohnson