Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated command HID classes not included in C++ build, despite being included in the build.gradle #6962

Closed
sciencewhiz opened this issue Aug 14, 2024 · 1 comment · Fixed by #6963
Labels
component: command-based WPILib Command Based Library type: bug Something isn't working.

Comments

@sciencewhiz
Copy link
Contributor

sciencewhiz commented Aug 14, 2024

Describe the bug
The generated files in wpilibNewCommands (ie CommandXboxController, PS4, etc) do not seem to be distributed in the build. They are not in the development doxygen (https://github.wpilib.org/allwpilib/docs/development/cpp/dir_56e1b1ed12101820b621b810be7ef57a.html) nor can a robot program reference CommandXboxController when using development artifacts. The examples do build, in the allwpilib build.

To Reproduce
Steps to reproduce the behavior:

  1. Create a RapidReactCommandRobot example project in VSCode
  2. switch it to use 2025 development artifacts
  3. build

Additional context
It does not appear that they are included in the built header zip, either, but they are referenced in build.gradle and seem like they should be included.

model {
components {
"${nativeName}Base" {
it.sources.cpp {
source {
srcDirs 'src/generated/main/native/cpp'
include '**/*.cpp'
}
exportedHeaders {
srcDirs 'src/generated/main/native/include'
}
}
}
"${nativeName}" {
it.sources.cpp.exportedHeaders {
srcDirs 'src/generated/main/native/include'
}
}
}

@sciencewhiz sciencewhiz changed the title Generated command HID classes not included in build, despite being included in the build.grade Generated command HID classes not included in build, despite being included in the build.gradle Aug 14, 2024
@sciencewhiz sciencewhiz changed the title Generated command HID classes not included in build, despite being included in the build.gradle Generated command HID classes not included in C++ build, despite being included in the build.gradle Aug 14, 2024
@calcmogul calcmogul added type: bug Something isn't working. component: command-based WPILib Command Based Library labels Aug 14, 2024
@PeterJohnson
Copy link
Member

PeterJohnson commented Aug 14, 2024

The generated source and include directories need to be added to the zip tasks in shared/javacpp/publish.gradle, similarly to how that is done in wpilibc/publish.gradle.

sciencewhiz added a commit to Beachbot330/allwpilib that referenced this issue Aug 14, 2024
Fixes wpilibsuite#6962
Don't specially include ntcore generated files from build directory in doxygen, as they are now pregenerated in source
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: command-based WPILib Command Based Library type: bug Something isn't working.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants