Skip to content

Commit

Permalink
Fix issues with test program (#582)
Browse files Browse the repository at this point in the history
DoubleSolenoid was double allocated
negative PID gain
  • Loading branch information
sciencewhiz authored Dec 29, 2023
1 parent bd85850 commit e033db2
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/test/java/robotbuilder/TestUtils.java
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ public static RobotTree generateTestTree() {
arm.add(pid);
pid.getProperty("P").setValueAndUpdate(2);
pid.getProperty("I").setValueAndUpdate(1);
pid.getProperty("D").setValueAndUpdate(-1);
pid.getProperty("D").setValueAndUpdate(0);
pid.getProperty("Send to SmartDashboard").setValueAndUpdate(true);
pid.getProperty("Continuous").setValueAndUpdate(true);
RobotComponent motor = new RobotComponent("Motor", "Motor Controller", tree);
Expand Down Expand Up @@ -165,7 +165,8 @@ public static RobotTree generateTestTree() {
subsystems.add(dblSol);
RobotComponent doubleSolenoid2 = new RobotComponent("Double Solenoid", "Double Solenoid", tree);
//Needed until #422 is fixed
doubleSolenoid2.getProperty("Reverse Channel (Solenoid)").setValueAndUpdate("2");
doubleSolenoid2.getProperty("Forward Channel (Solenoid)").setValueAndUpdate("3");
doubleSolenoid2.getProperty("Reverse Channel (Solenoid)").setValueAndUpdate("4");
dblSol.add(doubleSolenoid2);

// Create a simple OI
Expand Down

0 comments on commit e033db2

Please sign in to comment.