Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Migrate plugin to React and implement initial version of new plugin #53

Closed
8 of 16 tasks
orballo opened this issue Nov 5, 2018 · 1 comment · Fixed by #73
Closed
8 of 16 tasks

Migrate plugin to React and implement initial version of new plugin #53

orballo opened this issue Nov 5, 2018 · 1 comment · Fixed by #73
Assignees
Labels

Comments

@orballo
Copy link

orballo commented Nov 5, 2018

Migration:

  • Update dependencies
  • Wire up React
  • Wire up MST
  • Wire up styled-components
  • Wire up grommet
  • Config Webpack
  • Config Babel
  • Create PHP function to map a MST snapshot with the settings

Initial implementation:

  • Create new settings
  • Remove old settings functions
  • Write activation function
  • Write deactivation function
  • Write update function
  • Write uninstall function
  • Build Frontity page
  • Build Settings page

The script added to the admin site will run every time a page is loaded, even if they are not the pages of the plugin. We should find a way to make the script load only in the needed pages, and if it's not possible the script should prevent React from running.


The current wp_pwa_settings should be named frontity_settings. We need to be careful not to loose the old settings, and copy the values to the new ones before deleting them. We should look if there is a plugin_update hook of some kind to this purpose.

@orballo orballo added this to the 🏭 new-plugin milestone Nov 5, 2018
@orballo orballo self-assigned this Nov 5, 2018
orballo pushed a commit that referenced this issue Nov 5, 2018
orballo pushed a commit that referenced this issue Nov 20, 2018
orballo pushed a commit that referenced this issue Nov 21, 2018
orballo pushed a commit that referenced this issue Nov 21, 2018
orballo pushed a commit that referenced this issue Nov 21, 2018
orballo pushed a commit that referenced this issue Nov 23, 2018
This was referenced Dec 4, 2018
orballo pushed a commit that referenced this issue Dec 4, 2018
orballo pushed a commit that referenced this issue Dec 11, 2018
orballo pushed a commit that referenced this issue Dec 11, 2018
orballo pushed a commit that referenced this issue Dec 12, 2018
orballo pushed a commit that referenced this issue Dec 12, 2018
orballo pushed a commit that referenced this issue Dec 12, 2018
orballo pushed a commit that referenced this issue Dec 13, 2018
orballo pushed a commit that referenced this issue Dec 13, 2018
orballo pushed a commit that referenced this issue Dec 14, 2018
orballo pushed a commit that referenced this issue Dec 14, 2018
orballo pushed a commit that referenced this issue Dec 14, 2018
orballo pushed a commit that referenced this issue Dec 14, 2018
orballo pushed a commit that referenced this issue Dec 14, 2018
orballo pushed a commit that referenced this issue Dec 17, 2018
orballo pushed a commit that referenced this issue Dec 17, 2018
orballo pushed a commit that referenced this issue Dec 21, 2018
orballo pushed a commit that referenced this issue Dec 21, 2018
@ghost ghost removed the needs review label Dec 21, 2018
@frontibotito
Copy link
Contributor

🎉 This issue has been resolved in version 1.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants