Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deleteOrder mutation #99

Merged

Conversation

kidunot89
Copy link
Member

@kidunot89 kidunot89 commented Jul 5, 2019

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix branch (right side). Don't pull request from your master!

What does this implement/fix? Explain your changes.

Implements deleteOrder mutation.

NOTE: User cap requirements are the same and createOrder and updateOrder.

  • OrderMutationsTest updated.

Example usage

mutation deleteOrder( $input: DeleteOrderInput! ) {
    DeleteOrder( input: $input ) {
        clientMutationId
        order {
            ...order fields
        }
    }
}

DeleteOrderInput definition

'clientMutationId' => array(
	'type'        => array( 'non_null' => 'String' ),
	'description' => __( 'Unique ID for mutation', 'wp-graphql-woocommerce' ),
),
'id'                      => array(
	'type'        => 'ID',
	'description' => __( 'Order global ID', 'wp-graphql-woocommerce' ),
),
'orderId'             => array(
	'type'        => 'Int',
	'description' => __( 'Order WP ID', 'wp-graphql-woocommerce' ),
),

Does this close any currently open issues?

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

Operating System: Ubuntu 18.04

WordPress Version: 5.2

@kidunot89 kidunot89 added the new mutations Feature adds mutation(s) to the schema label Jul 5, 2019
@kidunot89 kidunot89 self-assigned this Jul 5, 2019
Copy link
Contributor

@renatonascalves renatonascalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions! :)

includes/model/class-crud-cpt.php Show resolved Hide resolved
includes/mutation/class-order-delete.php Outdated Show resolved Hide resolved
includes/mutation/class-order-delete.php Outdated Show resolved Hide resolved
tests/_support/Helper/crud-helpers/order.php Show resolved Hide resolved
@kidunot89 kidunot89 merged commit 9a8eb46 into wp-graphql:release-v0.2.0 Jul 6, 2019
@kidunot89 kidunot89 deleted the feature/delete-order-mutation branch July 6, 2019 15:29
@kidunot89 kidunot89 mentioned this pull request Jul 7, 2019
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new mutations Feature adds mutation(s) to the schema
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants