Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updateItemQuantities mutation #106

Merged

Conversation

kidunot89
Copy link
Member

…tation.

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix branch (right side). Don't pull request from your master!

What does this implement/fix? Explain your changes.

Refactors updateItemQuantity mutation to updateItemQuantities.

NOTE: As a convenience, if 0 is passed as the quantity the item will be removed from the cart.

  • CartMutationsTest updated.
  • CartItemQuantityInput type added.

Example usage

mutation ( $input: UpdateItemQuantitiesInput! ) {
    updateItemQuantities( input: $input ) {
        clientMutationId
        updated {
            ...cart item fields
        }
        removed {
            ...cart item fields
        }
        items {
            ...cart item fields
        }
    }
}

UpdateItemQuantitiesInput definition

'items' => array(
	'type'        => array( 'list_of' => 'CartItemQuantityInput' ),
	'description' => __( 'Cart item being updated', 'wp-graphql-woocommerce' ),
),

CartItemQuantityInput definition

'key'      => array(
	'type'        => array( 'non_null' => 'ID' ),
	'description' => __( 'Cart item being updated', 'wp-graphql-woocommerce' ),
),
'quantity' => array(
	'type'        => array( 'non_null' => 'Int' ),
	'description' => __( 'Cart item\'s new quantity', 'wp-graphql-woocommerce' ),
),

Does this close any currently open issues?

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

Operating System: Ubuntu 18.04

WordPress Version: 5.2

@kidunot89 kidunot89 added enhancement New feature or request new mutations Feature adds mutation(s) to the schema labels Jul 11, 2019
@kidunot89 kidunot89 self-assigned this Jul 11, 2019
@kidunot89 kidunot89 changed the title "updateItemQuantity" mutation refactored to "updateItemQuantities" mu… updateItemQuantities mutation Jul 11, 2019
@kidunot89 kidunot89 merged commit 6406e41 into wp-graphql:release-v0.2.0 Jul 11, 2019
@kidunot89 kidunot89 deleted the feature/update-item-quantities branch July 11, 2019 20:04
@kidunot89 kidunot89 mentioned this pull request Jul 11, 2019
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new mutations Feature adds mutation(s) to the schema
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant