Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

fix: deprecation warning #389

Merged
merged 3 commits into from
Jul 22, 2024
Merged

fix: deprecation warning #389

merged 3 commits into from
Jul 22, 2024

Conversation

josephfusco
Copy link
Member

@josephfusco josephfusco commented Jul 22, 2024

This PR includes cherry picked changes from develop that were missing from master in order to resolve #382

@josephfusco josephfusco changed the title Resolve deprecation warning fix: deprecation warning Jul 22, 2024
@josephfusco josephfusco marked this pull request as ready for review July 22, 2024 16:06
@josephfusco josephfusco requested a review from jasonbahl July 22, 2024 16:07
@jasonbahl
Copy link
Contributor

The Docker environment for automated tests is currently broken and we will not be fixing it in this repo as it will be archived in favor of the re-architected version of the WPGraphQL for ACF plugin: https://github.com/wp-graphql/wpgraphql-acf

To test this functionality I:

  • imported the following ACF Field Group: acf-export-2024-07-22.json
  • published a post with values in the fields
  • queried for the fields, executing the deprecated resolvers:
{
  post(id: 7229, idType: DATABASE_ID) {
    id
    databaseId
    uri
    acfDeprecationTest {
      imageFieldTest {
        sourceUrl
      }
      taxomomyFieldTest {
        name
        slug
      }
    }
  }
}

Data is returned as expected and the deprectated methods are no longer executed.

@jasonbahl jasonbahl merged commit a76b8ac into master Jul 22, 2024
1 of 10 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants