This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
#254 - add back missing type declaration for options pages. #257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying Options Page type declaration was removed in v0.5.0 release.
See: https://github.com/wp-graphql/wp-graphql-acf/pull/250/files?file-filters%5B%5D=.php&file-filters%5B%5D=.woff2&file-filters%5B%5D=.xml&file-filters%5B%5D=.yml&file-filters%5B%5D=dotfile#diff-a561f3a494f34edd4c3f2e83c25c8d4a9dc217eeeaed4385c735040450230ac0L1765
This PR adds it back and fixes null values being returned for option page values.
Steps to Reproduce
Adding the following Options Page:
Then assigning an ACF Field Group to the Options Page:
Then populating the settings field:
Before
Querying the text field in the settings returns no value
After
Querying the text field in the Settings returns the expected value
Closes #254