Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding issue on creation lines for htaccess file #2

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

AleTorrisi
Copy link
Collaborator

Proposed changes

Scenario: use a not latin language (in example Chinese), then save permalinks. Default rules set by WordPress in the .htaccess file are wrong and cause 500 error.

The pull request wants fix this issue adding a needed encoding when the htaccess file is written again adding new rules.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)

Checklist

  • Linting and tests pass locally with my changes
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] I have added necessary documentation (if appropriate)

Further comments

@wpscholar wpscholar merged commit 203f0e5 into master Jan 13, 2025
@wpscholar wpscholar deleted the fix/500error-encoding-issue branch January 13, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants