Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show full command after using the --prompt flag #5322

Merged
merged 6 commits into from
Aug 26, 2020

Conversation

dishitpala
Copy link
Contributor

#4995 Display full command after all prompts are submitted.

Screenshot 2019-11-27 at 2 10 01 AM

Copy link
Member

@schlessera schlessera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should make use of WP_CLI\Utils\assoc_args_to_str() here.

Also, please add a Behat test for this.

php/WP_CLI/Dispatcher/Subcommand.php Outdated Show resolved Hide resolved
@dishitpala
Copy link
Contributor Author

@schlessera

  • Address your feedback in this commit
  • Need some time to learn Behat

@schlessera
Copy link
Member

@dishitpala Are you still up for adding a Behat test here?

@dishitpala
Copy link
Contributor Author

@schlessera

By any chance, can we merge this PR and create another issue for a test case?
As I am struggling to manage time to learn Behat.

If we can't merge PR without a test-case, then I will manage to write the test-case.

Please let me know your thought on this.

Thanks.

@schlessera
Copy link
Member

No worries, I'll look into adding a test to this myself.

@thrijith
Copy link
Member

No worries, I'll look into adding a test to this myself.

Hi @schlessera, I've taken the liberty to add tests for the change, please let me know if something needs change, Thanks!

Thanks for the PR @dishitpala!

php/WP_CLI/Dispatcher/Subcommand.php Outdated Show resolved Hide resolved
php/WP_CLI/Dispatcher/Subcommand.php Outdated Show resolved Hide resolved
@schlessera schlessera added this to the 2.5.0 milestone Aug 26, 2020
@schlessera schlessera merged commit 339ee0f into wp-cli:master Aug 26, 2020
@schlessera schlessera changed the title Show full command after using the --prompt flag Show full command after using the --prompt flag Aug 26, 2020
@schlessera
Copy link
Member

Thanks for the PR, @dishitpala !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants