Avoid displaying default delimiter on regex fail in db search. #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbachhuber
approved these changes
Oct 13, 2017
Done in wp-cli/search-replace-command#40 |
danielbachhuber
added a commit
that referenced
this pull request
Nov 18, 2022
Avoid displaying default delimiter on regex fail in db search.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #46 and wp-cli/search-replace-command#30
Avoids displaying default delimiter on regex fail in db search.
If a regex contains an error, then the message displayed appears like this in the default Gnome Terminal on Ubuntu 17.04:
and probably doesn't look any better in other environments.
This PR "spells out" the error message when using the default delimiter, eg:
(A similar PR would need to be done for
search-replace.)