Lessen context duplication in db search. #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbachhuber
approved these changes
Oct 13, 2017
danielbachhuber
added a commit
that referenced
this pull request
Nov 18, 2022
Lessen context duplication in db search.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #54 and PRs wp-cli/search-replace-command#35 and wp-cli/php-cli-tools#123
Lessens context duplication in
db searchby shortening and appending context if it overlaps with the next match.This duplicates the loop logic in
search-replace --logby using a$last_offset, which improves output and performance.Also adds the re-check of encoding per value done in that PR so as not to mistakenly detect all legacy-encoded input as ASCII if the first value happens to be that.
Also exercises the
safe_substr()fix more by adding test to search with large data.