Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

innerhtml cleanup 2 #3675

Merged
merged 2 commits into from
Sep 13, 2023
Merged

innerhtml cleanup 2 #3675

merged 2 commits into from
Sep 13, 2023

Conversation

jarveson
Copy link
Contributor

  • small cleanup and jsx conversions for more 'hotpath' elements
  • few ms speed up here and there, no super major speed increase

@jarveson
ui: use jsx fragments instead of div
c211c92 
 - just ensuring markup says same as before

Signed-off-by: jarves <jarveson@gmail.com>
@jarveson
ui: more innerhtml -> jsx conversions
48dab3b 
 - small cleanup and change to jsx for 'hotpath' elements

Signed-off-by: jarves <jarveson@gmail.com>
@jarveson jarveson merged commit f7763e2 into wowsims:master Sep 13, 2023
@jarveson jarveson deleted the jake/innerhtml-part2 branch September 13, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jarveson