Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crit Cap for Auto Attack Display #2774

Closed
where-fore opened this issue Mar 13, 2023 · 0 comments · Fixed by #3847
Closed

Crit Cap for Auto Attack Display #2774

where-fore opened this issue Mar 13, 2023 · 0 comments · Fixed by #3847

Comments

@where-fore
Copy link
Contributor

Is your feature request related to a problem? Please describe.
For dual wielding auto attacks, your crit chance is capped lower than your abilities crit chance - autos are single roll, which can miss or glance, which cannot crit. This means that each specific simulation character with different hit/exp/crit has different auto attack crit caps, and will run into strange simulation results when going over or under their crit cap, if they are unaware of the mechanic, or simply if they didn't realize a specific setting/gear gave them wasted crit past their cap, or increased their cap and realized more crit from simply adding some hit.

As an example, the regular phase 2 BIS ring for an Assassination Rogue is Loop of the Agile, which gives crit rating, and is slightly better in almost all setups over Band of Lights, which gives hit rating. If you specifically have fairly low hit and the Dark Matter trinket (which gives a large amount of crit on proc), then you are sufficiently over crit cap during the Dark Matter proc and Band of Lights will suddenly sim better than Loop of the Agile.

Describe the solution you'd like
I am not sure the best implementation, but for my data-hungry brain I would love to see a breakdown of:

  1. Auto attack crit cap statically
  2. Auto attack crit cap during crit-increasing temporary buffs available to the current simulation character
  3. Your crit in relation to both of those
    Maybe when hovering over your "Melee Crit" stat on the display tab.

That being said, knowing which procs give you crit is likely too much hardcoding, and maybe the sim should just display it in the results tab somehow - maybe measure each auto attacks attack table, and if you're crit capped, note a number of auto attacks that were X% over crit cap? Some sort of warning when the sim runs and finds itself over crit cap?

Additional context
I mostly write this to raise awareness and start brainstorming, this is an issue that is only very rarely relevant now, but will become more relevant as the public starts to sim higher crit chance characters eg. Icecrown Citadel gearing.

secretbis added a commit to secretbis/wotlk that referenced this issue Oct 8, 2023
Added in the form of a new spec-gated row in the character stats pane

Text is green if below crit cap, red if above, white if equal

Tooltip includes several details about said crit cap, including mechanics modifiers, cap final value, and how much the cap can be raised.

Resolves wowsims#2774
lime-green pushed a commit that referenced this issue Oct 14, 2023
Added in the form of a new spec-gated row in the character stats pane

Text is green if below crit cap, red if above, white if equal

Tooltip includes several details about said crit cap, including mechanics modifiers, cap final value, and how much the cap can be raised.

Resolves #2774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant