Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: there can be multiple tranceivers on the same address on different chains. #23

Merged
merged 7 commits into from
Jul 2, 2024
Merged

fix: there can be multiple tranceivers on the same address on different chains. #23

merged 7 commits into from
Jul 2, 2024

Conversation

Foivos
Copy link
Collaborator

@Foivos Foivos commented Jul 1, 2024

No description provided.

@milapsheth milapsheth merged commit 7c47f13 into feat/update-axelar-transceiver Jul 2, 2024
1 check passed
@nik-suri nik-suri deleted the fix/same-axelar-address branch July 2, 2024 15:45
milapsheth added a commit that referenced this pull request Jul 2, 2024
@Foivos @djb15 @milapsheth
fix: address axelar transceiver audit comments (#22)
eae15a0 
* Squashed commit of the following:

commit 0e817ae
Merge: 8e24478 4c4b3f0
Author: Foivos <foivos@umich.edu>
Date:   Fri Jun 28 17:20:07 2024 +0300

    Merge remote-tracking branch 'origin/feat/address-audit-comments' into feat/address-audit-comments

commit 8e24478
Author: Foivos <foivos@umich.edu>
Date:   Fri Jun 28 17:19:29 2024 +0300

    sqush commits

commit 4c4b3f0
Author: Foivos <foivos@umich.edu>
Date:   Fri Jun 28 13:29:45 2024 +0300

    fix error

commit c167b14
Author: Foivos <foivos@umich.edu>
Date:   Fri Jun 28 13:09:16 2024 +0300

    add tests for checks

commit 92465cf
Author: Foivos <foivos@umich.edu>
Date:   Fri Jun 28 13:06:37 2024 +0300

    added additional check for setAxelarChainId

commit 6ff7928
Author: Foivos <foivos@umich.edu>
Date:   Thu Jun 27 17:57:29 2024 +0300

    forge fmt

commit c639f11
Author: Foivos <foivos@umich.edu>
Date:   Thu Jun 27 16:53:02 2024 +0300

    fix end to end tests

commit ad272af
Author: Foivos <foivos@umich.edu>
Date:   Thu Jun 27 16:31:47 2024 +0300

    fix more capitaliaztion

commit c45a2de
Author: Foivos <foivos@umich.edu>
Date:   Thu Jun 27 16:14:01 2024 +0300

    differnet import again

commit 8273c1a
Merge: 6eac1b9 1c0f731
Author: Foivos <foivos@umich.edu>
Date:   Thu Jun 27 16:13:06 2024 +0300

    Merge remote-tracking branch 'origin/main' into feat/address-audit-comments

commit 6eac1b9
Author: Foivos <foivos@umich.edu>
Date:   Thu Jun 27 16:11:50 2024 +0300

    try different import

commit 6aaf137
Author: Foivos <foivos@umich.edu>
Date:   Thu Jun 27 16:07:57 2024 +0300

    trying more stuff

commit 7bd8932
Author: Foivos <foivos@umich.edu>
Date:   Thu Jun 27 16:05:02 2024 +0300

    trying to fix CLI

commit f6e60a2
Author: Foivos <foivos@umich.edu>
Date:   Thu Jun 27 16:04:22 2024 +0300

    try a different import

commit 53b0e53
Author: Foivos <foivos@umich.edu>
Date:   Thu Jun 27 15:53:22 2024 +0300

    revert change

commit 4e576be
Author: Foivos <foivos@umich.edu>
Date:   Thu Jun 27 15:46:19 2024 +0300

    forge fmt

commit 2d6af58
Author: Foivos <foivos@umich.edu>
Date:   Thu Jun 27 15:44:06 2024 +0300

    fix import in test

commit 7eb17a4
Author: Foivos <foivos@umich.edu>
Date:   Wed Jun 26 20:39:14 2024 +0300

    remove confusing comment

commit 2c000b2
Author: Foivos <foivos@umich.edu>
Date:   Tue Jun 25 11:14:28 2024 +0300

    restrict use of setAxelarChainId

commit 56ff882
Author: Canh Trinh <canhtrinh@users.noreply.github.com>
Date:   Mon Jun 24 15:17:03 2024 -0400

    Update test/axelar/AxelarTransceiver.t.sol

    Co-authored-by: Milap Sheth <milap.sheth2010@gmail.com>

commit be34917
Author: Canh Trinh <canhtrinh@users.noreply.github.com>
Date:   Mon Jun 24 15:15:19 2024 -0400

    Update test/axelar/AxelarTransceiver.t.sol

    Co-authored-by: Milap Sheth <milap.sheth2010@gmail.com>

commit dd1288c
Author: Canh Trinh <canhtrinh@users.noreply.github.com>
Date:   Mon Jun 24 15:14:47 2024 -0400

    Update src/axelar/AxelarTransceiver.sol

    Co-authored-by: Milap Sheth <milap.sheth2010@gmail.com>

commit 2fa5cde
Author: Foivos <foivos@umich.edu>
Date:   Wed Jun 19 14:29:49 2024 +0300

    run fmt

commit d5159a5
Author: Foivos <foivos@umich.edu>
Date:   Wed Jun 19 14:16:09 2024 +0300

    Added better tests

commit f03f0eb
Author: Foivos <foivos@umich.edu>
Date:   Wed Jun 19 13:23:07 2024 +0300

    Add validation for setAxelarChainId

commit f4c441a
Author: Foivos <foivos@umich.edu>
Date:   Wed Jun 19 13:16:48 2024 +0300

    Add event to setAxelarChainId

commit 02eaea5
Merge: 43e425c d7a07d9
Author: Foivos <foivos@umich.edu>
Date:   Wed Jun 19 13:16:21 2024 +0300

    Merge branch 'feat/update-wormhole-examples-version' into feat/address-audit-comments

commit d7a07d9
Author: Foivos <foivos@umich.edu>
Date:   Thu Jun 13 14:55:07 2024 +0300

    forge fmt

commit 1ed9e1d
Author: Foivos <foivos@umich.edu>
Date:   Thu Jun 13 14:46:17 2024 +0300

    Fix axelar transceiver to include version

commit e642d8d
Author: Foivos <foivos@umich.edu>
Date:   Thu Jun 13 14:29:58 2024 +0300

    update wormhole-examples to new main

commit 1b6520a
Author: Foivos <foivos@umich.edu>
Date:   Tue Jun 11 18:19:43 2024 +0300

    added more destriptive error message

commit ef0dc87
Author: Foivos <foivos@umich.edu>
Date:   Tue Jun 11 16:21:12 2024 +0300

    forge fmt

commit 5b66ae8
Author: Foivos <foivos@umich.edu>
Date:   Tue Jun 11 16:20:53 2024 +0300

    added a constant for easy identification

commit 4c3e078
Author: Foivos <foivos@umich.edu>
Date:   Tue Jun 11 13:47:16 2024 +0300

    tests now prperly check for reverts

commit b8b2bb3
Author: Foivos <foivos@umich.edu>
Date:   Mon Jun 10 15:12:06 2024 +0300

    run forge fmt again

commit fc2dfea
Author: Foivos <foivos@umich.edu>
Date:   Mon Jun 10 15:02:58 2024 +0300

    run forge fmt

commit d8e46e4
Author: Foivos <foivos@umich.edu>
Date:   Mon Jun 10 15:01:57 2024 +0300

    remove unused var

commit 30c5c6d
Author: Foivos <foivos@umich.edu>
Date:   Mon Jun 10 14:58:57 2024 +0300

    try to fix CI again

commit 4b76355
Author: Foivos <foivos@umich.edu>
Date:   Mon Jun 10 14:56:57 2024 +0300

    try to fix CI

commit 69e5f40
Author: Foivos <foivos@umich.edu>
Date:   Sun Jun 9 22:57:40 2024 +0300

    update readme

commit fe2b441
Author: Foivos <foivos@umich.edu>
Date:   Sat Jun 8 20:59:02 2024 +0300

    added a fail test if the address is not trusted.

commit d07ebe0
Author: Foivos <foivos@umich.edu>
Date:   Sat Jun 8 20:54:16 2024 +0300

    Added a receiving token test

commit c1041cb
Author: Foivos <foivos@umich.edu>
Date:   Fri Jun 7 12:00:44 2024 +0300

    added a script to set remote siblings

commit ad9e213
Author: Milap Sheth <milap.sheth2010@gmail.com>
Date:   Thu Jun 6 13:16:22 2024 -0400

    Update script/README.md

commit eebec31
Author: Milap Sheth <milap.sheth2010@gmail.com>
Date:   Thu Jun 6 13:16:14 2024 -0400

    Update script/README.md

commit d839bd4
Author: Milap Sheth <milap.sheth2010@gmail.com>
Date:   Thu Jun 6 13:06:25 2024 -0400

    Update src/axelar/AxelarTransceiver.sol

commit c482fcb
Author: Foivos <foivos@umich.edu>
Date:   Thu Jun 6 19:18:21 2024 +0300

    correct decoding of message

commit 6cda8f9
Author: Foivos <foivos@umich.edu>
Date:   Thu Jun 6 19:14:50 2024 +0300

    checking for immutable immutables

commit 985b915
Author: Foivos <foivos@umich.edu>
Date:   Thu Jun 6 19:10:30 2024 +0300

    remove unecesairy modifier

commit d9b4f6c
Author: Foivos <foivos@umich.edu>
Date:   Thu Jun 6 19:09:24 2024 +0300

    added some natspec

commit 709ff54
Author: Foivos <foivos@umich.edu>
Date:   Thu Jun 6 18:25:20 2024 +0300

    moved some errors

commit 4d98b15
Author: Foivos <foivos@umich.edu>
Date:   Thu Jun 6 14:07:38 2024 +0300

    add readme and rename dir

commit ac40e0d
Author: Foivos <foivos@umich.edu>
Date:   Thu Jun 6 14:03:48 2024 +0300

    update deployment script

commit f4fb0cb
Author: Foivos <foivos@umich.edu>
Date:   Wed Jun 5 18:04:51 2024 +0300

    added a deployment script

commit b446382
Author: Nikhil Suri <nikhilsuri@comcast.net>
Date:   Mon Jun 3 17:41:53 2024 -0700

    Fix CI and format

commit ca08e99
Author: Nikhil Suri <nikhilsuri@comcast.net>
Date:   Mon Jun 3 17:37:04 2024 -0700

    Fix OZ contracts issue

commit 01edb75
Author: Foivos <foivos@umich.edu>
Date:   Fri May 31 15:42:53 2024 +0300

    update tests a bit

commit ac31c4d
Author: Foivos <foivos@umich.edu>
Date:   Fri May 31 15:29:10 2024 +0300

    change some names

commit 1f25b44
Author: Foivos <foivos@interoplabs.io>
Date:   Fri May 31 15:28:39 2024 +0300

    Update src/axelar/AxelarTransceiver.sol

    Co-authored-by: Milap Sheth <milap.sheth2010@gmail.com>

commit 9f42e32
Author: Foivos <foivos@interoplabs.io>
Date:   Fri May 31 15:28:16 2024 +0300

    Update src/axelar/AxelarTransceiver.sol

    Co-authored-by: Milap Sheth <milap.sheth2010@gmail.com>

commit 9f2cd61
Author: Foivos <foivos@umich.edu>
Date:   Thu May 30 21:46:18 2024 +0300

    using payGas instead of payNativeGasForContractCall

commit a6d5211
Author: Foivos <foivos@umich.edu>
Date:   Thu May 30 21:37:53 2024 +0300

    using the gas service estimateGasFee

commit f3b02fe
Author: Foivos <foivos@umich.edu>
Date:   Thu May 30 21:26:00 2024 +0300

    fixed a naminginconsistency

commit 71f586f
Author: Foivos <foivos@umich.edu>
Date:   Thu May 30 21:23:57 2024 +0300

    some more comments addressed

commit 89ffcb6
Author: Foivos <foivos@umich.edu>
Date:   Thu May 30 21:01:00 2024 +0300

    remove cgp-solidity as it is unused

commit 72e05aa
Author: Foivos <foivos@umich.edu>
Date:   Thu May 30 20:59:33 2024 +0300

    address some comments

commit 5f75247
Author: Foivos <foivos@umich.edu>
Date:   Thu May 30 20:27:56 2024 +0300

    using axelar gmp executable

commit 23640f4
Author: Foivos <foivos@umich.edu>
Date:   Thu May 30 18:39:24 2024 +0300

    remove the proxy

commit 053d9fb
Merge: e4cbb67 c4361e7
Author: Foivos <foivos@umich.edu>
Date:   Thu May 30 18:35:57 2024 +0300

    Merge remote-tracking branch 'origin/main' into feat/axelar-transceiver

commit e4cbb67
Author: Foivos <foivos@umich.edu>
Date:   Thu May 30 18:27:22 2024 +0300

    Tests work

commit da28026
Author: Foivos <foivos@umich.edu>
Date:   Thu May 30 16:24:44 2024 +0300

    change oz to an older version

commit 356d603
Author: Foivos <foivos@umich.edu>
Date:   Wed May 29 18:16:28 2024 +0300

    rename storage_ to slot

commit 748b989
Author: Nikhil Suri <nikhilsuri@comcast.net>
Date:   Tue May 28 17:18:18 2024 -0700

    downgrade to oz v4.8.1

commit 32f2600
Author: Foivos <foivos@umich.edu>
Date:   Mon May 27 20:28:39 2024 +0300

    using Transceiver abstract contract

commit 490202f
Author: Foivos <foivos@umich.edu>
Date:   Fri May 24 16:51:52 2024 +0300

    fix the test

commit a228d68
Author: Foivos <foivos@umich.edu>
Date:   Fri May 24 16:02:45 2024 +0300

    added some tests

commit 96c4258
Author: Foivos <foivos@umich.edu>
Date:   Thu May 23 17:57:58 2024 +0300

    forge install: axelar-cgp-solidity

    v6.3.1

commit b31cda4
Author: Foivos <foivos@umich.edu>
Date:   Thu May 23 17:57:54 2024 +0300

    trying to add some tests

commit 62edca4
Author: Foivos <foivos@umich.edu>
Date:   Thu May 23 17:42:29 2024 +0300

    added a proxy as well

commit 06ed4c4
Author: Foivos <foivos@umich.edu>
Date:   Fri May 17 13:21:27 2024 +0300

    Added the rest of the files

commit cacecd0
Author: Foivos <foivos@umich.edu>
Date:   Fri May 17 13:16:19 2024 +0300

    add axelar tranceiver

* Fix submodule commit hash

* Update src/axelar/AxelarTransceiver.sol

* fix: there can be multiple tranceivers on the same address on different chains. (#23)

* fix it so that there can be multiple tranceivers on the same address on different chains.

* fix spelling error

* add token back

* add cast to bytes

* run forge fmt

* update examples-native-token-transfers

* try to revert to older package

---------

Co-authored-by: Dirk Brink <hello@dirk.tech>
Co-authored-by: Milap Sheth <milap.sheth2010@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleasew8t pleasew8t pleasew8t approved these changes

@milapsheth milapsheth milapsheth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Foivos @pleasew8t @milapsheth